Skip to content

Add German translation#277

Merged
tr7zw merged 3 commits intotr7zw:mainfrom
GulutGames:main
Mar 4, 2026
Merged

Add German translation#277
tr7zw merged 3 commits intotr7zw:mainfrom
GulutGames:main

Conversation

@GulutGames
Copy link
Contributor

Translation might not be 100% accurate

@coderabbitai
Copy link

coderabbitai bot commented Feb 22, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

Added a new German localization file de_de.json under EntityCulling assets, providing 27 key-value entries mapping UI labels, tab names, option names, and tooltips to German text.

Changes

Cohort / File(s) Summary
German Localization
src/main/resources/assets/entityculling/lang/de_de.json
New JSON file with 27 German translation entries for EntityCulling UI: titles, tab labels (General, Tick Culling, Entity Culling, Block Entity Culling), toggles, option labels, and tooltips (e.g., render nametags through walls, F3 info, skip culling, force display, block entity frustum culling).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add German translation' clearly and concisely summarizes the main change of adding a German language resource file (de_de.json) to the project.
Description check ✅ Passed The description 'Translation might not be 100% accurate' is related to the changeset, acknowledging a limitation of the German translation being added.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/main/resources/assets/entityculling/lang/de_de.json`:
- Around line 11-12: Standardize the German spelling for "Blockentitäten" across
the JSON by replacing the hyphenated form "Block-Entitäten" with the compound
"Blockentitäten" for the keys and tooltips referenced (e.g.,
"text.entityculling.tab.block_entity_culling" and
"text.entityculling.tab.block_entity_culling.tooltip" and the other related keys
around lines 21–23), ensuring all occurrences in this file use "Blockentitäten"
consistently and that tooltips preserve their existing wording aside from the
spelling change.
- Line 5: Replace the non-toggle wording in the German translation for the key
"key.entityculling.toggleBoxes": change the value "Culling-Boxen anzeigen" to
use the verb that conveys toggle semantics consistent with the sibling
"key.entityculling.toggle" (e.g., "Culling-Boxen umschalten") so the label
correctly reflects a toggle action.
- Line 24: Fix the typo in the German localization value for the key
"text.entityculling.blockEntityFrustumCulling.tooltip": change "anderere" to
"andere" so the sentence reads correctly; update the string value in
src/main/resources/assets/entityculling/lang/de_de.json for that key and keep
the surrounding punctuation and escaping unchanged.
- Line 25: The label for the key "text.entityculling.forceDisplayCulling" is
ambiguous in German; replace the current string with one that explicitly
mentions Minecraft's Display Entities (Anzeige-Entitäten), e.g. "Culling für
Anzeige-Entitäten erzwingen" (or similar phrasing like "Anzeige‑Entitäten:
Culling erzwingen") so it matches the tooltip terminology while keeping the
existing key name intact.

@tr7zw
Copy link
Owner

tr7zw commented Feb 22, 2026

Interessant, wie viel CodeRabbit spammen kann für lang files 😅

Translated "Bounding Box" to "Begrenzungsrahmen"
@sonarqubecloud
Copy link

@GulutGames
Copy link
Contributor Author

Übersetzung ist soweit fertig, nur bei der Übersetzung von "Block entity frustum culling" (Block-Entitäten-Frustum-Culling) bin ich mir nicht ganz sicher...

@tr7zw tr7zw merged commit ee0e628 into tr7zw:main Mar 4, 2026
2 checks passed
@tr7zw
Copy link
Owner

tr7zw commented Mar 4, 2026

Ich habe es überflogen, ich bin ehrlich, ich habe in 15 Jahren noch nie Minecraft in Deutsch gespielt, ich habe da gar kein Gefühl für, wie was übersetzt sein sollte.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants