Conversation
|
No actionable comments were generated in the recent review. 🎉 WalkthroughAdded a new German localization file Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/main/resources/assets/entityculling/lang/de_de.json`:
- Around line 11-12: Standardize the German spelling for "Blockentitäten" across
the JSON by replacing the hyphenated form "Block-Entitäten" with the compound
"Blockentitäten" for the keys and tooltips referenced (e.g.,
"text.entityculling.tab.block_entity_culling" and
"text.entityculling.tab.block_entity_culling.tooltip" and the other related keys
around lines 21–23), ensuring all occurrences in this file use "Blockentitäten"
consistently and that tooltips preserve their existing wording aside from the
spelling change.
- Line 5: Replace the non-toggle wording in the German translation for the key
"key.entityculling.toggleBoxes": change the value "Culling-Boxen anzeigen" to
use the verb that conveys toggle semantics consistent with the sibling
"key.entityculling.toggle" (e.g., "Culling-Boxen umschalten") so the label
correctly reflects a toggle action.
- Line 24: Fix the typo in the German localization value for the key
"text.entityculling.blockEntityFrustumCulling.tooltip": change "anderere" to
"andere" so the sentence reads correctly; update the string value in
src/main/resources/assets/entityculling/lang/de_de.json for that key and keep
the surrounding punctuation and escaping unchanged.
- Line 25: The label for the key "text.entityculling.forceDisplayCulling" is
ambiguous in German; replace the current string with one that explicitly
mentions Minecraft's Display Entities (Anzeige-Entitäten), e.g. "Culling für
Anzeige-Entitäten erzwingen" (or similar phrasing like "Anzeige‑Entitäten:
Culling erzwingen") so it matches the tooltip terminology while keeping the
existing key name intact.
|
Interessant, wie viel CodeRabbit spammen kann für lang files 😅 |
Translated "Bounding Box" to "Begrenzungsrahmen"
|
|
Übersetzung ist soweit fertig, nur bei der Übersetzung von "Block entity frustum culling" (Block-Entitäten-Frustum-Culling) bin ich mir nicht ganz sicher... |
|
Ich habe es überflogen, ich bin ehrlich, ich habe in 15 Jahren noch nie Minecraft in Deutsch gespielt, ich habe da gar kein Gefühl für, wie was übersetzt sein sollte. |



Translation might not be 100% accurate