This repository was archived by the owner on May 23, 2025. It is now read-only.
add a bottom sheet to confirm boosts and favs #5084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tak
reviewed
Apr 29, 2025
Collaborator
Tak
left a comment
Tak
left a comment
There was a problem hiding this comment.
Looks reasonable, I'll try it out
app/src/main/java/com/keylesspalace/tusky/adapter/StatusBaseViewHolder.java
Outdated
Show resolved
Hide resolved
|
|
||
| if (favourite) { | ||
| confirmFavourite(preferences) { | ||
| viewModel.favorite(true, status) |
Collaborator
There was a problem hiding this comment.
We really can't decide between favorite and favourite, huh
| val status = adapter?.peek(position)?.asStatusOrNull() ?: return | ||
|
|
||
| if (favourite) { | ||
| confirmReblog(preferences) { visibility -> |
Collaborator
There was a problem hiding this comment.
This should be confirmFavorite, right?
| viewModel.favorite(favourite, status) | ||
|
|
||
| if (favourite) { | ||
| confirmReblog(preferences) { visibility -> |
app/src/main/res/values/strings.xml
Outdated
| <string name="reblog_privacy_followers_only_description">Only your followers can see your boost</string> | ||
|
|
||
| <string name="reblog_confirm">Boost this post?</string> | ||
| <string name="favourite_confirm">Favourite this post?</string> |
Collaborator
There was a problem hiding this comment.
Is the base strings file uk english (favourite) or us english (favorite)?
Collaborator
Author
There was a problem hiding this comment.
It is US, I'll change it to favorite
Tak
approved these changes
Apr 30, 2025
connyduck
added a commit
that referenced
this pull request
May 17, 2025
It is not necessary because the settings are read when the buttons are clicked since #5084
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A better version for confirming boosts, because there is space for describing what the privacy options do.
This was quite difficult to get into theStatusBaseViewHolder, I had to add a callback that plays the button animation which is very hacky. It seems to work fine but I'm a bit worried about weird effects when the view holder gets recycled.I found a better way to do it without callback and without leaking views.