Skip to content

Replace deprecated xmldom with @xmldom/xmldom#55

Open
geoffcorey wants to merge 1 commit intotyrasd:masterfrom
geoffcorey:master
Open

Replace deprecated xmldom with @xmldom/xmldom#55
geoffcorey wants to merge 1 commit intotyrasd:masterfrom
geoffcorey:master

Conversation

@geoffcorey
Copy link
Copy Markdown

Should resolve the security issue reported in the deprecated xmldom package

✔ 12:20 ~/src/github.com/geoffcorey/jxon [master|…2] $ npm test

> jxon@2.0.0-beta.5 pretest /home/geoff/src/github.com/geoffcorey/jxon
> npm ls --depth=Infinity > /dev/null


> jxon@2.0.0-beta.5 test /home/geoff/src/github.com/geoffcorey/jxon
> npm run test-node && npm run test-webkit


> jxon@2.0.0-beta.5 test-node /home/geoff/src/github.com/geoffcorey/jxon
> mocha test/spec.js



  JXON
    .jsToXml > .xmlToJs
      ✓ should return return identical object 
    .jsToString > .stringToJs
      ✓ should return return identical object 
    .stringToJs > .jsToString > .stringToJs
      ✓ should return return identical object 
    empty nodes should be empty when trueIsEmpty = false
      ✓ <empty/> should remain empty 
      ✓ <empty></empty> should remain empty 
    parseValues option
      ✓ 11.0 should remain string 
    json treatment
      ✓ treat null values equally as empty objects 
      ✓ deal with pure arrays with jumped indexes 
      ✓ ignores prototypal inherited properties of arrays 
      ✓ deal with pure arrays with jumped indexes and null values 
      ✓ skip undefined properties 
    .each
      ✓ one node should iterate 
      ✓ multiple nodes should iterate 
    xml namespaces
      ✓ should parse xmlns 
      ✓ as property 


  15 passing (16ms)


> jxon@2.0.0-beta.5 test-webkit /home/geoff/src/github.com/geoffcorey/jxon
> browserify test/spec.js > test/spec.browserify.js && mocha-phantomjs test/index.html



  JXON
    .jsToXml > .xmlToJs
      ✓ should return return identical object 
    .jsToString > .stringToJs
      ✓ should return return identical object 
    .stringToJs > .jsToString > .stringToJs
      ✓ should return return identical object 
    empty nodes should be empty when trueIsEmpty = false
      ✓ <empty/> should remain empty 
      ✓ <empty></empty> should remain empty 
    parseValues option
      ✓ 11.0 should remain string 
    json treatment
      ✓ treat null values equally as empty objects 
      ✓ deal with pure arrays with jumped indexes 
      ✓ ignores prototypal inherited properties of arrays 
      ✓ deal with pure arrays with jumped indexes and null values 
      ✓ skip undefined properties 
    .each
      ✓ one node should iterate 
      ✓ multiple nodes should iterate 
    xml namespaces
      ✓ should parse xmlns 
      ✓ as property 


  15 passing (10ms)

@geoffcorey
Copy link
Copy Markdown
Author

@tyrasd ?

@visaivis
Copy link
Copy Markdown

@tyrasd 🥺

@mizeranipicpay
Copy link
Copy Markdown

@tyrasd 🥺?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants