This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Add tox.ini for running tests+flake8 against python 2.6, 2.7, 3.4. Fix flake8 issues. #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Figured out my py26 issue (I hadn't installed requirements-py2.txt). |
EvanKrall
changed the title
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't see another scripted way to run tests locally (other than nosetests, which afaik doesn't set up virtualenv for you).
I've added a tox.ini, set it to run nosetests+flake8 against py2.7 and py3.4. I have a py26 section in there, but the tests don't currently pass (unittest in py26 is missing assertGreater and assertIsInstance) so I didn't include it by default.
I also cleaned up some issues that flake8 raised.