debian/copyright: Fix issues reported by licenserecon

[adombeck]

Declare copyright and licenses for files for which licenserecon aka lrc reported discrepancies.

Also fixes some formatting issues. See commit messages for details.

Context: We're about to merge canonical/desktop-engineering#97 which runs lrc as part of the build-deb action.

UDENG-8725

[adombeck]

There is one issue left which lrc reports:

en: Versions: licenserecon '11.0'  licensecheck '3.3.9-1ubuntu2'

Parsing Source Tree  ....
Reading d/copyright  ....
Running licensecheck ....

d/copyright      | licensecheck

GPL-3+           | GPL-3             meson.build

debian/copyright declares the license GPL-3.0+ for Files: *, meson.build declares license : ['GPL3', 'CC BY-SA 4.0']. Should we change one of those?

Alternatively, we could skip lrc in the build-deb action via:

diff --git a/.github/workflows/build-deb.yaml b/.github/workflows/build-deb.yaml
index dfb69d7fd..902e2afd9 100644
--- a/.github/workflows/build-deb.yaml
+++ b/.github/workflows/build-deb.yaml
@@ -22,6 +22,7 @@ jobs:
         uses: canonical/desktop-engineering/gh-actions/common/build-debian@main
         with:
           docker-image: ubuntu:${{ env.UBUNTU_VERSION }}
+          lrc: skip
 
       - name: Install generated debs
         uses: kohlerdominik/docker-run-action@v2.0.0

[adombeck]

Alternatively, we could skip lrc in the build-deb action

Or only skip the check for meson.build by adding it to debian/lrc.config. I'll tentatively push a commit which does that.

[3v1n0]

Thanks