feat: docs, delivery RBAC, and session/policy metrics (gaps 6-9)#39
Merged
feat: docs, delivery RBAC, and session/policy metrics (gaps 6-9)#39
Conversation
Gap 6 — docs/CONFIGURATION.md:
Complete env var reference (80+ vars across 13 sections)
Gap 7 — docs/DEPLOYMENT-TLS.md:
Step-by-step TLS setup guide (cert generation, Helm values,
verification, troubleshooting) for all 5 transports
Gap 8 — Helm delivery RBAC:
Separate ServiceAccount + Role + RoleBinding for K8s delivery tools
(gated by kubernetesBackend.deliveryTools.enabled)
Gap 9 — Session/policy Prometheus metrics:
workspace_sessions_created_total, workspace_sessions_closed_total,
workspace_discovery_requests_total, workspace_invocations_denied_total{reason}
Added to existing KPIMetrics system, emitted on /metrics endpoint
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes 4 gaps in a single PR — docs, Helm, and metrics.
Gap 6: Configuration Reference
docs/CONFIGURATION.md— 80+ env vars across 13 sectionsGap 7: TLS Deployment Guide
docs/DEPLOYMENT-TLS.md— step-by-step for all 5 transportsGap 8: Delivery RBAC
charts/templates/rbac-delivery.yaml— separate SA + Role + RoleBindingkubernetesBackend.deliveryTools.enabledGap 9: Session/Policy Metrics
/metrics:workspace_sessions_created_totalworkspace_sessions_closed_totalworkspace_discovery_requests_totalworkspace_invocations_denied_total{reason="..."}kpi_metrics_test.goTest plan
go build ./...— cleango vet ./...— cleango test ./...— 16 packages passhelm lint— cleanhelm template --set kubernetesBackend.deliveryTools.enabled=true— delivery SA + Role renders🤖 Generated with Claude Code