Skip to content

Fix and *RETAIN* version check#491

Closed
bomoko wants to merge 2 commits intomainfrom
chore-fix-version-check-retain
Closed

Fix and *RETAIN* version check#491
bomoko wants to merge 2 commits intomainfrom
chore-fix-version-check-retain

Conversation

@bomoko
Copy link
Copy Markdown
Contributor

@bomoko bomoko commented Mar 7, 2026

This PR addresses the logic issue with the overriding of the PersistentPreRun function in the command hierarchy that is leading to the inconsistent running of the version update check across commands.

Here we move this to the cobra OnInitialize() initializer's slice (some discussion on the differences are here, although not particularly useful - https://stackoverflow.com/questions/68766567/oninitialize-vs-persistentprerun-in-a-cobra-based-cli)

Closing issues

closes #487

Note - there is a second PR that will remove the functionality except for running in the "version" command explicitly (up to maintainer to choose).

@bomoko bomoko changed the title Fix and retain version check Fix and *RETAIN* version check Mar 7, 2026
@bomoko
Copy link
Copy Markdown
Contributor Author

bomoko commented Mar 8, 2026

#493 should sort the linting errors

@bomoko bomoko force-pushed the chore-fix-version-check-retain branch from 20e4cbe to 7e52eca Compare March 10, 2026 01:29
@shreddedbacon
Copy link
Copy Markdown
Member

Closing as #492 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Check for Updates" feature appears to not work

2 participants