Merged
Conversation
Contributor
Author
|
#493 should sort the linting errors |
bomoko
force-pushed
the
chore-fix-version-check-remove
branch
from
e276034 to
e3ae21a
Compare
Member
|
I prefer this over #491 |
shreddedbacon
force-pushed
the
chore-fix-version-check-remove
branch
from
e3ae21a to
442318c
Compare
shreddedbacon
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #491
Here we do two things. Move the version update check logic into the version command (the logic seems sound, but we can still remove it wholesale). There was also some non-version check logic in the PersistenPreRun function (namely, the StrictHostCheck details) which I have moved into cobra's initializer's slice (as with the previous version of the PR)
Closing issues
closes #487
Note - there is a first PR (#491) that will retain the functionality (up to maintainer to choose).