-
Notifications
You must be signed in to change notification settings - Fork 4
docs: Reorganize ValidMind Library "portal" around sorted Jupyter Notebooks #1168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code reviewFound 2 issues that need attention: Issue 1: Incorrect relative paths in
|
|
Lighthouse check resultsShow Lighthouse scoresFolder depth level checked: 0 Commit SHA: 29492e6 Modify the workflow to check a different depth:
|
nrichers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great PR! Wow. 👏 I especially love the clean structure of the "How to run tests and test suites" section.
Just a few minor comments I found while comparing the old and new side-by-side.
|
@validbeck the validate CI failure will go away after https://github.com/validmind/installation/pull/189 is merged, FYI. |
Co-authored-by: Nik Richers <nik@validmind.ai>
Co-authored-by: Nik Richers <nik@validmind.ai>
Validate docs site✓ INFO: A live preview of the docs site is available — Open the preview |
Execute training notebooks for PRs✓ INFO: Live previews are available — |
Pull Request Description
What and why?
This PR pulls in the updated notebook structure from validmind/validmind-library#475 and revamps the ValidMind Library "portal" to feature our more organized notebooks:
old-portal.mov
new-portal.mov
1. Sidebar restructured (
site/developer/_sidebar.yaml)The developer sidebar received a significant reorganization:
testing-overview.qmdwith nested sections for Explore tests, Run tests (with sub-sections Configuring tests and Documentation tests), and Custom tests.feature-overview.qmdwith auto-populated sections for Data and datasets, Metrics, and Scoring.use_cases/paths with**/*.ipynbglobs (instead of the oldcode_samples/+**catch-all).2. Build scripts replaced and expanded
The old single script
site/scripts/update_code_samples_sidebar.pywas deleted and replaced by two scripts insite/scripts/developer-sidebar/:update_use_cases.py— Auto-discoversuse_cases/subdirectories and updates both the sidebar YAML andsamples-jupyter-notebooks.qmdwith per-category listing tiles (panel tabset).update_how_tos.py— Auto-discovershow_to/subdirectories and updates both the sidebar YAML and the newfeature-overview.qmdwith per-topic listing tiles.site/Makefile— Minor adjustments to accommodate the new script paths and calling the new scripts.Both Python scripts generate Quarto listing blocks with grid layouts and panel tabsets, borrowing the tabbed tile pattern already used on the "Test descriptions" page. They update both the sidebar and their respective landing pages in a single run.
3. New and updated landing pages
developer/how-to/testing-overview.qmd— New page (replacing the olddeveloper/model-testing/testing-overview.qmd) serving as the landing for "Run tests & test suites" under the How-To section.developer/how-to/feature-overview.qmd— New landing page for "Use library features" with auto-populated notebook listing tiles grouped by topic.developer/samples-jupyter-notebooks.qmd— Rewritten to use panel tabsets auto-populated by theupdate_use_cases.pyscript.developer/validmind-library.qmd— Updated to reflect the new structure and section names.developer/test-descriptions.qmd— Moved up fromdeveloper/model-testing/todeveloper/and adjusted.developer/model-testing/test-sandbox.qmdmoved todeveloper/how-to/test-sandbox.qmdto live alongside the new How-To pages.4. Comprehensive broken link fixes
Links referencing the old
code_samples/paths were updated across ~30 files spanning:How to test
Review the live previews
Test the
developer-sidebarscriptsgh pr checkout 1168cd siteuse_casesdirectory and add a test notebook:_source/validmind-library/notebooks/use_cases/test_directorytest.ipynbmkdir -p _source/validmind-library/notebooks/use_cases/test_directory python3 -c 'import json; n={"nbformat":4,"nbformat_minor":4,"metadata":{},"cells":[{"cell_type":"markdown","metadata":{},"source":["test"]}]}; open("_source/validmind-library/notebooks/use_cases/test_directory/test.ipynb","w").write(json.dumps(n, indent=1))'how_todirectory and add a test notebook:_source/validmind-library/notebooks/how_to/test_directorytest.ipynbmkdir -p _source/validmind-library/notebooks/how_to/test_directory python3 -c 'import json; n={"nbformat":4,"nbformat_minor":4,"metadata":{},"cells":[{"cell_type":"markdown","metadata":{},"source":["test"]}]}; open("_source/validmind-library/notebooks/how_to/test_directory/test.ipynb","w").write(json.dumps(n, indent=1))'make notebookssite/developer/_sidebar.yamland confirm:site/developer/how-to/feature-overview.qmdsite/developer/samples-jupyter-notebooks.qmdWhat needs special review?
n/a
Dependencies, breaking changes, and deployment notes
Pulls from the notebook reshuffle in validmind/validmind-library#475.
Release notes
We've restructured our {{< var validmind.developer >}} guides to better familiarize users with the capabilities of the {{< var vm.developer >}}. Detailed information on how to use the {{< var vm.developer >}}'s rich features — such as how to run tests, as well examples on how to apply {{< var vm.product >}} to your custom use case can all be found under the new and improved:
{{< var validmind.developer >}}{.button}
Checklist