Merged
Conversation
cachafla
reviewed
Jun 23, 2025
Contributor
PR SummaryThis PR enhances the diagnostic functions in the test suite by ensuring that only numeric and categorical feature columns are processed. In the OverfitDiagnosis function, the code now concatenates numeric and categorical feature columns and raises an error if no valid columns are found. Similarly, the WeakspotsDiagnosis function has been modified to filter the feature columns based on the numeric and categorical columns available in the dataset, and to raise a ValueError if none remain. These changes help avoid issues when non-relevant feature columns are present and improve the accuracy of the analysis conducted by these functions. Test Suggestions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Tests:
These tests takes all the listed all the feature columns for for plots and data. However, if columns are not numerical or categorical types, it doesn't produce good plots.
What and why?
To produce relevant output
How to test
Run quick start documentation notebook demo notebook. you can use your dataset to test further.
What needs special review?
Dependencies, breaking changes, and deployment notes
Release notes
Checklist