You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the utility function that retrieves judge configuration, the PR fixes a bug where the wrong object was being checked for type. The condition now correctly verifies if the model of the provided judge_embeddings is an instance of the Embeddings class instead of checking judge_llm's model. This change ensures that the configuration behaves as expected when embeddings are used.
In the asynchronous logging functionality, the PR refactors the logging of test results. It introduces an additional logging task by appending an API call to log test results, and removes the redundant logging block that handled table logging. The update to the content_id formatting in the metadata update call improves clarity and consistency.
Test Suggestions
Create tests for get_judge_config to verify that when judge_embeddings is provided with a valid Embeddings model, it returns the expected output without error.
Verify that providing an invalid judge_embeddings (or a model not of type Embeddings) correctly raises a ValueError.
Write integration tests to ensure that the asynchronous logging (alog_test_result, alog_figure, update_metadata) is called with the correct parameters under various conditions (with figures, with tables omitted, and with metrics).
Test the new content_id formatting for the update_metadata function to confirm that it produces consistent and expected results.
juanmleng
deleted the
juan/sc-11248/hotfix-test-results-not-being-logged-to-api-when-no-tables-present
branch
July 14, 2025 20:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugSomething isn't workinginternalNot to be externalized in the release notes
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What and why?
How to test
quickstart_model_documentation.ipynband check all test results are logged in the UI and database.What needs special review?
Dependencies, breaking changes, and deployment notes
Release notes
Checklist