Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ description = "ValidMind Library"
license = "Commercial License"
name = "validmind"
readme = "README.pypi.md"
version = "2.8.27"
version = "2.8.28"

[tool.poetry.dependencies]
aiohttp = {extras = ["speedups"], version = "*"}
Expand Down
2 changes: 1 addition & 1 deletion validmind/__version__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "2.8.27"
__version__ = "2.8.28"
2 changes: 1 addition & 1 deletion validmind/ai/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def get_judge_config(judge_llm=None, judge_embeddings=None):
"ensure that you are connected to the ValidMind API and confirm ValidMind AI is enabled for your account."
)
if isinstance(judge_embeddings, FunctionModel) and judge_embeddings is not None:
if isinstance(judge_llm.model, BaseChatModel):
if isinstance(judge_embeddings.model, Embeddings):
judge_embeddings = judge_embeddings.model
else:
raise ValueError(
Expand Down
26 changes: 14 additions & 12 deletions validmind/vm_models/result/result.py
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,15 @@ async def log_async(
# Default empty dict if None
config = config or {}

tasks.append(
api_client.alog_test_result(
result=self.serialize(),
section_id=section_id,
position=position,
config=config,
)
)

if self.metric is not None:
# metrics are logged as separate entities
tasks.append(
Expand All @@ -466,15 +475,6 @@ async def log_async(
)
)

if self.tables:
tasks.append(
api_client.alog_test_result(
result=self.serialize(),
section_id=section_id,
position=position,
config=config,
)
)
if self.figures:
tasks.extend(
[api_client.alog_figure(figure) for figure in (self.figures or [])]
Expand All @@ -488,9 +488,11 @@ async def log_async(

tasks.append(
update_metadata(
content_id=f"{content_id}::{revision_name}"
if content_id
else f"test_description:{self.result_id}::{revision_name}",
content_id=(
f"{content_id}::{revision_name}"
if content_id
else f"test_description:{self.result_id}::{revision_name}"
),
text=self.description,
)
)
Expand Down