Skip to content

Hotfix: Remove LLM is_configured() Check from Test Description Generation#418

Merged
johnwalz97 merged 2 commits intoprodfrom
hotfix/remove-llm-configured-check
Aug 26, 2025
Merged

Hotfix: Remove LLM is_configured() Check from Test Description Generation#418
johnwalz97 merged 2 commits intoprodfrom
hotfix/remove-llm-configured-check

Conversation

@johnwalz97
Copy link
Contributor

Pull Request Description

What and why?

We no longer need the is_configured() check in the test description generation flow as we call the ValidMind API to generate descriptions. Removing as it will cause test description generation to fail in environments where an LLM provider is not configured.

How to test

What needs special review?

Dependencies, breaking changes, and deployment notes

Release notes

Checklist

  • What and why
  • Screenshots or videos (Frontend)
  • How to test
  • What needs special review
  • Dependencies, breaking changes, and deployment notes
  • Labels applied
  • PR linked to Shortcut
  • Unit tests added (Backend)
  • Tested locally
  • Documentation updated (if required)
  • Environment variable additions/changes documented (if required)

@johnwalz97 johnwalz97 added bug Something isn't working internal Not to be externalized in the release notes labels Aug 26, 2025
@github-actions
Copy link
Contributor

PR Summary

This pull request introduces two main changes:

  1. The project version is updated from 2.9.1 to 2.9.2 in both the pyproject.toml and the version.py file. This update reflects minor changes or improvements in the project without modifying the functional behavior.

  2. In the description generation logic (in validmind/ai/test_descriptions.py), the check using the function is_configured has been removed from the condition that determines if a description should be generated in the background. This change simplifies the logic by removing a circular import dependency and the associated conditional check. The condition now directly evaluates if description generation should occur when tables or figures exist and if LLM descriptions are enabled.

Test Suggestions

  • Verify that the project version is correctly updated and that version-checking functionalities reflect the new version number.
  • Test the description generation functionality, ensuring that descriptions are generated as expected when tables or figures are provided and LLM descriptions are enabled, even without performing the configuration check.
  • Create test cases for scenarios where description generation should not trigger, such as when neither tables nor figures are provided or when LLM descriptions are disabled.

@johnwalz97 johnwalz97 requested a review from juanmleng August 26, 2025 15:28
Copy link
Contributor

@cachafla cachafla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@johnwalz97 johnwalz97 merged commit 497de1f into prod Aug 26, 2025
11 checks passed
@johnwalz97 johnwalz97 deleted the hotfix/remove-llm-configured-check branch August 26, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants