Skip to content

Hotfix: Remove LLM is_configured() Check from Test Description Generation #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnwalz97 merged 2 commits into from
Aug 26, 2025
Merged

Hotfix: Remove LLM is_configured() Check from Test Description Generation #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3233306
hotfix: remove check for is configured for test description generation
johnwalz97 Aug 26, 2025
1ada5ce
2.9.2
johnwalz97 Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ description = "ValidMind Library"
license = "Commercial License"
name = "validmind"
readme = "README.pypi.md"
version = "2.9.1"
version = "2.9.2"

[tool.poetry.dependencies]
aiohttp = {extras = ["speedups"], version = "*"}
Expand Down
2 changes: 1 addition & 1 deletion validmind/__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "2.9.1"
__version__ = "2.9.2"
10 changes: 1 addition & 9 deletions validmind/ai/test_descriptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,15 +191,7 @@ def get_result_description(
not in ["0", "false"]
)

# TODO: fix circular import
from validmind.ai.utils import is_configured

if (
should_generate
and (tables or figures)
and llm_descriptions_enabled
and is_configured()
):
if should_generate and (tables or figures) and llm_descriptions_enabled:
# get description future and set it as the description in the metadata
# this will lazily retrieved so it can run in the background in parallel
description = background_generate_description(
Expand Down