fix: /api/flow SSE endpoint hangs E2E health checks — add HEAD method support#248
Open
vivekchand wants to merge 1 commit intomainfrom
Open
fix: /api/flow SSE endpoint hangs E2E health checks — add HEAD method support#248vivekchand wants to merge 1 commit intomainfrom
vivekchand wants to merge 1 commit intomainfrom
Conversation
… support E2E test checks /api/flow with curl and expects a 200 response code. The endpoint is an infinite SSE stream, so curl hangs forever waiting for the response to complete. Add HEAD method support that returns 200 immediately without starting the generator, enabling health checks and E2E tests to verify the endpoint is alive without blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
E2E health check tests
/api/flowwithcurl -s -o /dev/null -w '%{http_code}'expecting a 200 response code. However,/api/flowis an infinite SSE (Server-Sent Events) streaming endpoint — curl hangs indefinitely waiting for the stream to close, never capturing the HTTP status code.Fix
Add
HEADmethod support to both/api/flowand/api/flow-events. HEAD requests return 200 immediately without starting the SSE generator, enabling health checks and E2E tests to verify the endpoint is alive without blocking.Test
curl -I http://localhost:8900/api/flow # Returns 200 immediately