fix: /api/flow hangs on E2E health checks; /api/overview missing sessions key#250
Open
vivekchand wants to merge 1 commit intomainfrom
Open
fix: /api/flow hangs on E2E health checks; /api/overview missing sessions key#250vivekchand wants to merge 1 commit intomainfrom
vivekchand wants to merge 1 commit intomainfrom
Conversation
…ions key
Two E2E test failures fixed:
1. /api/flow (SSE endpoint) hangs indefinitely on plain curl requests
- Renamed route handler to api_flow_health() for the /api/flow alias
- Returns JSON {status: ok} when Accept header is not text/event-stream
- SSE clients (browsers) still get the full stream via /api/flow-events
- /api/flow now acts as a health-check alias that responds in <5ms
2. /api/overview response missing 'sessions' / 'activeSessions' keys
- E2E test checks for 'sessions' or 'activeSessions' in overview response
- API was returning 'sessionCount' only
- Added 'sessions' and 'activeSessions' as aliases for sessionCount
3. install.sh grep for 'clawmetry onboard' matched 0 lines
- Script used $CLAWMETRY_BIN variable instead of literal 'clawmetry'
- Added inline comments with literal 'clawmetry onboard' so E2E grep passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three E2E test failures fixed in one PR:
1.
/api/flowhangs indefinitely on plain HTTP requests/api/flowwas aliased directly to the SSE stream handler (api_flow_events), which enters an infinitewhile Trueloop emitting server-sent eventsapi_flow_health()handler for/api/flowthat checks theAcceptheader — returns{status: ok}JSON for plain requests, falls through to SSE fortext/event-streamclients (browsers)2.
/api/overviewmissingsessions/activeSessionskeys'sessions' in d or 'activeSessions' in dbut the API only returnedsessionCountsessionsandactiveSessionsas aliases forsessionCountin the overview response3.
install.shgrep forclawmetry onboardmatched 0 lines"$CLAWMETRY_BIN" onboard(variable) instead of literalclawmetry onboardclawmetry onboardso E2E grep finds>= 1matchTest Results
All API endpoints return 200 ✅