-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore: enable all staticcheck rules #8992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8992 +/- ##
==========================================
+ Coverage 59.70% 59.71% +0.01%
==========================================
Files 370 370
Lines 40326 40325 -1
==========================================
+ Hits 24075 24080 +5
- Misses 14770 14773 +3
+ Partials 1481 1472 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
/kind changelog-not-required |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
812a0f9
to
4d0f42e
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM - Excellent code quality improvements
This PR successfully enables all remaining staticcheck rules and fixes the resulting issues across 45 files. All changes are purely linter-driven improvements with no logical modifications:
Key improvements:
- Removes redundant field accesses and method calls
- Simplifies boolean logic patterns
- Eliminates unnecessary struct traversals
- Improves overall code readability
Impact: ✅ No functional changes, pure code quality enhancement
Risk: ✅ Very low - only stylistic improvements
Coverage: ✅ Comprehensive across the codebase
Great work on cleaning up technical debt and improving static analysis coverage!
Approved 👍
Thank you for contributing to Velero!
Please add a summary of your change
Enable staticcheck rules and fixes issues
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog
) or comment/kind changelog-not-required
on this PR.site/content/docs/main
.