Fixed shared message object reference across locales#315
Open
pg0404-44 wants to merge 4 commits intowikimedia:masterfrom
Open
Fixed shared message object reference across locales#315pg0404-44 wants to merge 4 commits intowikimedia:masterfrom
pg0404-44 wants to merge 4 commits intowikimedia:masterfrom
Conversation
Added a personal note about the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I changed
Updated the message store so locale messages are copied before being stored or merged.
Why
Issue #223 happens when the same object is loaded for multiple locales. Because the object reference is shared, later updates can overwrite values across languages.
Each locale now keeps an independent message object, so loading additional messages no longer causes all languages to become the same.
Fixes #223