Skip to content

Fixed shared message object reference across locales #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pg0404-44 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed shared message object reference across locales #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a9f3ace
Add personal contribution note to README
pg0404-44 Mar 18, 2026
d7bb906
Update README.md
pg0404-44 Mar 18, 2026
e7904b3
Fix shared message object reference across locales
pg0404-44 Mar 26, 2026
95d47c8
Fix shared message object reference across locales
pg0404-44 Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,6 @@ Example qqq.json:
```

In MediaWiki and its hundreds of extensions, message documentation is a strictly followed practice. There is a grunt task to check whether all messages are documented or not. See https://www.npmjs.org/package/grunt-banana-checker

This is my first contribution.
[npm]: https://img.shields.io/npm/v/@wikimedia/jquery.i18n.svg
[npm-url]: https://npmjs.com/package/@wikimedia/jquery.i18n
16 changes: 9 additions & 7 deletions src/jquery.i18n.messagestore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,15 @@
* @param {string} locale
* @param {Object} messages
*/
set: function ( locale, messages ) {
if ( !this.messages[ locale ] ) {
this.messages[ locale ] = messages;
} else {
this.messages[ locale ] = $.extend( this.messages[ locale ], messages );
}
},
set: function ( locale, messages ) {
var clonedMessages = $.extend( true, {}, messages );

if ( !this.messages[ locale ] ) {
this.messages[ locale ] = clonedMessages;
} else {
this.messages[ locale ] = $.extend( true, {}, this.messages[ locale ], clonedMessages );
}
},

/**
*
Expand Down