Fix: reject promise on non-404 errors in jsonMessageLoader (fixes #255)#317
Open
haniyakonain wants to merge 1 commit intowikimedia:masterfrom
Open
Fix: reject promise on non-404 errors in jsonMessageLoader (fixes #255)#317haniyakonain wants to merge 1 commit intowikimedia:masterfrom
haniyakonain wants to merge 1 commit intowikimedia:masterfrom
Conversation
…imedia#255) Fixes wikimedia#255 The `jsonMessageLoader` function was resolving the promise on ALL errors, including invalid JSON. Now it only resolves on 404 (for fallback handling) and rejects on all other errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #255
The
jsonMessageLoaderfunction was resolving the promise on ALL errors, including invalid JSON. Now it only resolves on 404 (for fallback handling) and rejects on all other errors.