Skip to content

Fix: reject promise on non-404 errors in jsonMessageLoader (fixes #255) #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haniyakonain wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: reject promise on non-404 errors in jsonMessageLoader (fixes #255) #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/jquery.i18n.messagestore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@
.done( deferred.resolve )
.fail( function ( jqxhr, settings, exception ) {
$.i18n.log( 'Error in loading messages from ' + url + ' Exception: ' + exception );
// Ignore 404 exception, because we are handling fallabacks explicitly
deferred.resolve();
// Ignore 404 exception, because we are handling fallbacks explicitly
if ( jqxhr.status === 404 ) {
deferred.resolve();
} else {
deferred.reject( exception );
}
} );

return deferred.promise();
}

/**
* See https://github.com/wikimedia/jquery.i18n/wiki/Specification#wiki-Message_File_Loading
*/
Expand Down