feat(TER-347): Add unified data source bindings for TypeScript#51
Draft
ericpsimon wants to merge 2 commits intomainfrom
Draft
feat(TER-347): Add unified data source bindings for TypeScript#51ericpsimon wants to merge 2 commits intomainfrom
ericpsimon wants to merge 2 commits intomainfrom
Conversation
68559bc to
382315e
Compare
- Moved all Node.js binding files from term-guard-node/ to node/term-guard/ - Updated Cargo.toml workspace configuration - Fixed term-guard dependency path in node/term-guard/Cargo.toml - Updated GitHub Actions workflow paths - Added proper .gitignore for Node.js dependencies and build artifacts - Simplified NAPI CI workflow: - Removed matrix builds (out of scope for this project) - Single Linux build for development - Combined build and test into one job - Only upload artifacts from main branch - Updated to use npm instead of yarn - Aligned with project CI patterns
382315e to
f46d0d3
Compare
- Convert index.js to index.ts with proper TypeScript types - Convert test/index.test.js to test/index.test.ts with interfaces - Add comprehensive TypeScript type definitions in index.d.ts - Update package.json to use TypeScript compilation pipeline - Configure tsconfig.json for CommonJS module output - Update build scripts to compile TypeScript before NAPI build - Add tsx for running TypeScript tests directly - Update .gitignore and .npmignore for TypeScript workflow - Remove old JavaScript files in favor of TypeScript
8caf22a to
4180ec6
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Key Features
Data Source Support
TypeScript Migration
.jsfiles to.tswith full type definitionstsconfig.jsonwith strict type checkingChanges
term-guard-node/tonode/term-guard/package.jsonto use TypeScript toolchain.npmignorefor clean npm packagesTest Plan
tsxExample Usage
🤖 Generated with Claude Code