Fix Reader feed image display for VIDEO card types #22325
+39
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- VIDEO cards now show featured images when available - Updated buildFeaturedImageVisibility() to support VIDEO cards with images - Updated buildFeaturedImageUrl() for consistent behavior across card types - Added comprehensive unit tests for VIDEO card image display - Fixes issue where VIDEO posts with thumbnails didn't show images Fixes wordpress-mobile#21332
Contributor
|
Thank you for your contribution @AdamLiga !! Also, you can run detekt locally by using |
AdamLiga
force-pushed
the
fix/reader-video-card-featured-images
branch
from
a755cb9 to
2b5e6dc
Compare
- Removed unused ReaderCardType.PHOTO import - Removed unused ReaderCardType.DEFAULT import - Addresses SonarCloud code analysis warnings
|
adalpari
approved these changes
Nov 25, 2025
Contributor
adalpari
left a comment
adalpari
left a comment
There was a problem hiding this comment.
Thank you for your contribution! The fix looks good to me :) !
Contributor
|
| App Name | WordPress | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22325-23d45bd | |
| Commit | 23d45bd | |
| Direct Download | wordpress-prototype-build-pr22325-23d45bd.apk |
Contributor
|
| App Name | Jetpack | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22325-23d45bd | |
| Commit | 23d45bd | |
| Direct Download | jetpack-prototype-build-pr22325-23d45bd.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21332
Description
Testing instructions