-
Notifications
You must be signed in to change notification settings - Fork 73
EditCounter: + approx autoedits count using tags #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm uncertain about the label: it really should be short, but it should be clearly said that this is an approximation. Meanwhile, I settled for |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
============================================
- Coverage 71.30% 69.28% -2.03%
- Complexity 1275 1326 +51
============================================
Files 46 46
Lines 3792 3998 +206
============================================
+ Hits 2704 2770 +66
- Misses 1088 1228 +140 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
And I suppose the page join I removed was for T325492? I spose I might as well readd it. |
MusikAnimal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny little requested change to the wikitext output. Otherwise this looks good and I'm happy to approve.
It'd be nice, but not required, to have a unit test to reinforce the EditCounter::countAutoEdits() method, and perhaps also AutomatedEditsHelper::getTags(). For the former, you could stub EditCounterRepository::getEditSizeData() to return the data structure we expect, and have it include a tag or two that we don't consider automated. You'll also need to stub AutomatedEditsHelper::getTags() to return tags we do consider automated. We only need a few examples: say, AWB, contenttranslation, and mobile edit. AWB counts as automated. contentranslation would also, except that it has contribs: true which I think means we don't want to count it? Then mobile edit is one we wouldn't count.
Let me know if you need help!
Co-authored-by: MusikAnimal <MusikAnimal@users.noreply.github.com>
|
@MusikAnimal : if you don't mind, I'd rather make that test after we merge this or #551 , because 551 already has the provider &c set up to do this. If we merge 551 then adapting this (relying on that) will be easy; if we merge this first I can add the tests to 551. |
Added just above the small/large edits.
Changes:
auto-edits-taggedmessage for thisBug: T342402