fix(linstorvolumemanager): don't allow InUse volumes to be deleted #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klmp200
force-pushed
the
linstor_protect_in_use_volume
branch
from
2e28b7a to
a86786c
Compare
klmp200
force-pushed
the
linstor_protect_in_use_volume
branch
from
a86786c to
e7af4ae
Compare
Millefeuille42
approved these changes
Nov 7, 2025
Wescoeur
requested changes
Nov 13, 2025
| :param: volume_uuid | ||
| :rtype: dict | ||
| """ | ||
| for volume in self.get_resources_info().values(): |
Member
There was a problem hiding this comment.
The cost can be really important. I guess we can extract a few logic of get_resources_info to reduce this expense.
Author
There was a problem hiding this comment.
I've introduced some caching mechanism to mitigate this issue :)
drivers/linstorvolumemanager.py
Outdated
|
|
||
| raise LinstorVolumeManagerError( | ||
| f"Could not find info about volume `{volume_uuid}`", | ||
| LinstorVolumeManagerError.ERR_VOLUME_DESTROY |
Member
There was a problem hiding this comment.
Suggested change
| LinstorVolumeManagerError.ERR_VOLUME_DESTROY | |
| LinstorVolumeManagerError.ERR_VOLUME_NOT_EXISTS |
drivers/linstorvolumemanager.py
Outdated
|
|
||
| return resources | ||
|
|
||
| def get_resource_info(self, volume_uuid: str) -> Dict: |
Member
There was a problem hiding this comment.
Suggested change
| def get_resource_info(self, volume_uuid: str) -> Dict: | |
| def get_resource_info(self, volume_uuid: str) -> Dict[str, Any]: |
Not the best suggestion but meh. :p I think we should try to be explicit even when it's not simple. Of course, within the limits of readability!
klmp200
force-pushed
the
linstor_protect_in_use_volume
branch
from
e7af4ae to
91916fe
Compare
klmp200
force-pushed
the
linstor_protect_in_use_volume
branch
4 times, most recently
from
ae8c064 to
91916fe
Compare
Fix some typo in docstring Signed-off-by: Antoine Bartuccio <antoine.bartuccio@vates.tech>
klmp200
force-pushed
the
linstor_protect_in_use_volume
branch
from
91916fe to
a90db03
Compare
Millefeuille42
approved these changes
Nov 17, 2025
Millefeuille42
left a comment
Millefeuille42
left a comment
There was a problem hiding this comment.
Not blocking. Other than that, LGTM.
drivers/linstorvolumemanager.py
Outdated
Comment on lines
1759
to
1761
| Give all resources info with provided uuid on current group name. | ||
| :param volume_uuid str: volume uuid to search for | ||
| :rtype: dict |
There was a problem hiding this comment.
Suggested change
| Give all resources info with provided uuid on current group name. | |
| :param volume_uuid str: volume uuid to search for | |
| :rtype: dict | |
| Give all resource info related to provided UUID in the current group. | |
| :param volume_uuid str: volume uuid to search for | |
| :rtype: dict |
Author
There was a problem hiding this comment.
Done :)
I've also matched the rtype to the type hint ;)
Check for usage status before deleting a linstor volume and raise an appropriate error if this happens Signed-off-by: Antoine Bartuccio <antoine.bartuccio@vates.tech>
klmp200
force-pushed
the
linstor_protect_in_use_volume
branch
from
a90db03 to
e85e3e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for usage status before deleting a linstor volume and raise an appropriate error if this happens