Open
Conversation
Collaborator
|
this looks good, but is missing unit tests, @sgasioro can we add some? |
Author
|
Yes, sounds good! Any particular examples I should work off of? E.g. can mimic some pieces of: https://github.com/xopt-org/Xopt/blob/main/xopt/tests/generators/bayesian/test_model_constructor.py |
Collaborator
|
not a bad place to start, I could be a stickler and say that we should aim for 100% coverage, but we aren't there yet, so getting a reasonable level of coverage would be good |
Collaborator
|
@sgasioro if we can resolve merge conflicts, I think we would be good to merge. Would be good to have this for further releases of bax-algorithms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add model constructor and pipelining for ensemble models using BoTorch EnsembleModel. Implementation here for an MCDropout NN ensemble, but should be generalizable for proper NN ensemble, or even random forests. Focused on BAX here.
NB: generally standalone,
get_training_datais main difference without explicitly separate logic. See xopt-org/bax_algorithms#3 for an example.