Skip to content

Upgrade bindgen#23

Closed
youknowone wants to merge 2 commits intomainfrom
upgrade-bindgen
Closed

Upgrade bindgen#23
youknowone wants to merge 2 commits intomainfrom
upgrade-bindgen

Conversation

@youknowone
Copy link
Owner

@youknowone youknowone commented Sep 8, 2025

Summary by CodeRabbit

  • Chores
    • Upgraded a build-time codegen dependency to a newer patch release to stay current; no user-facing behavior changes.
    • Updated CI matrix for macOS/iOS: disabled fail-fast for macOS, removed several platform targets, and commented/disabled a few platform-specific checks to streamline CI runs.

@coderabbitai
Copy link

coderabbitai bot commented Sep 8, 2025

Walkthrough

Updated the bindgen dependency in bindgen/Cargo.toml from "0.69" to "0.72.1" and adjusted the GitHub Actions CI matrix in .github/workflows/rust.yml by setting fail-fast: false for the sys-macos strategy and removing/commenting several matrix entries (including AuthenticationServices and others). No public APIs changed.

Changes

Cohort / File(s) Summary
Dependency bump
bindgen/Cargo.toml
Bumped bindgen dependency from "0.69" to "0.72.1".
CI workflow adjustments
.github/workflows/rust.yml
Set fail-fast: false for sys-macos; removed IMServicePlugIn, JavaNativeFoundation, and ExposureNotification from matrices; commented-out/disabled AuthenticationServices, BusinessChat, and AddressBookUI entries in sys-macos/sys-ios.

Sequence Diagram(s)

sequenceDiagram
    participant Dev as Developer (push/PR)
    participant GH as GitHub Actions
    participant Matrix as Job Matrix
    participant macOS as sys-macos jobs
    participant iOS as sys-ios jobs
    Dev->>GH: push PR
    GH->>Matrix: expand matrices (updated)
    Note right of Matrix: bindgen bump is in repo\nCI matrix entries removed/commented
    Matrix->>macOS: run macOS jobs (fail-fast: false)
    Matrix->>iOS: run iOS jobs
    macOS-->>GH: job results (no early cancel)
    iOS-->>GH: job results
    GH-->>Dev: aggregate results
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "Upgrade bindgen" succinctly and accurately describes the primary change in this PR—the bindgen dependency bump in bindgen/Cargo.toml (0.69 → 0.72.1); although the PR also contains GitHub Actions workflow tweaks, the title clearly communicates the main intent and is concise for reviewers scanning history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Poem

I nibble versions, soft and bright,
A crate hops up into the light.
CI pruned branches, jobs run free,
Mac and iOS hum along with me.
Small changes, big thumps — a happy rabbit's night. 🐇✨

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 25f6a0e and 693e77b.

📒 Files selected for processing (1)
  • .github/workflows/rust.yml (2 hunks)
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch upgrade-bindgen

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0c261fe and 25f6a0e.

📒 Files selected for processing (1)
  • .github/workflows/rust.yml (2 hunks)


sys-macos:
strategy:
fail-fast: false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Good call on disabling fail-fast; consider capping parallelism to control CI time/queue pressure.

Large matrices on macOS runners can saturate the queue. Add max-parallel to keep throughput predictable.

Apply this diff:

   strategy:
-      fail-fast: false
+      fail-fast: false
+      max-parallel: 8
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
fail-fast: false
strategy:
fail-fast: false
max-parallel: 8
🤖 Prompt for AI Agents
In .github/workflows/rust.yml around line 24, the workflow disables fail-fast
but doesn't cap matrix concurrency; add a max-parallel setting under the job's
strategy.matrix (for example max-parallel: 2 or 4) to limit how many matrix jobs
run concurrently so macOS runner queue pressure and CI time are controlled.

@youknowone
Copy link
Owner Author

closed by #24

@youknowone youknowone closed this Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant