Skip to content

Upgrade bindgen #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
youknowone wants to merge 2 commits into from
Closed

Upgrade bindgen #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c261fe
Upgrade bindgen
youknowone Sep 8, 2025
693e77b
CI
youknowone Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:

sys-macos:
strategy:
fail-fast: false
Copy link

@coderabbitai coderabbitai bot Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Good call on disabling fail-fast; consider capping parallelism to control CI time/queue pressure.

Large matrices on macOS runners can saturate the queue. Add max-parallel to keep throughput predictable.

Apply this diff:

   strategy:
-      fail-fast: false
+      fail-fast: false
+      max-parallel: 8
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
fail-fast: false
strategy:
fail-fast: false
max-parallel: 8
🤖 Prompt for AI Agents 
In .github/workflows/rust.yml around line 24, the workflow disables fail-fast
but doesn't cap matrix concurrency; add a max-parallel setting under the job's
strategy.matrix (for example max-parallel: 2 or 4) to limit how many matrix jobs
run concurrently so macOS runner queue pressure and CI time are controlled.

matrix:
feature: [
AGL,
Expand Down Expand Up @@ -110,7 +111,6 @@ jobs:
HealthKit,
Hypervisor,
ICADevices,
IMServicePlugIn,
IOBluetooth,
IOBluetoothUI,
IOKit,
Expand All @@ -124,7 +124,6 @@ jobs:
InstantMessage,
Intents,
IntentsUI,
JavaNativeFoundation,
JavaRuntimeSupport,
JavaScriptCore,
Kerberos,
Expand Down Expand Up @@ -247,11 +246,11 @@ jobs:
AssetsLibrary,
AudioToolbox,
AudioUnit,
AuthenticationServices,
# AuthenticationServices,
AutomaticAssessmentConfiguration,
BackgroundAssets,
BackgroundTasks,
BusinessChat,
# BusinessChat,
CFNetwork,
CallKit,
CarPlay,
Expand Down Expand Up @@ -288,7 +287,6 @@ jobs:
DeviceDiscoveryExtension,
EventKit,
EventKitUI,
ExposureNotification,
ExtensionFoundation,
ExtensionKit,
ExternalAccessory,
Expand Down
2 changes: 1 addition & 1 deletion bindgen/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ include = ["*.toml", "/src"]
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
bindgen = "0.69"
bindgen = "0.72.1"
serde = { version = "1.0", features = ["derive"] }
toml = "0.6"
derive_more = { version = "0.99" }
Expand Down
Loading