chore(logging): convert explicit re-export shim → sys.modules-alias bridge#246
Open
ywatanabe1989 wants to merge 1 commit intodevelopfrom
Open
chore(logging): convert explicit re-export shim → sys.modules-alias bridge#246ywatanabe1989 wants to merge 1 commit intodevelopfrom
ywatanabe1989 wants to merge 1 commit intodevelopfrom
Conversation
…ridge scitex-logging is already a standalone package; the umbrella was using an explicit re-export of ~50 symbols (which means the list drifts whenever scitex-logging adds new APIs). Replace with the same sys.modules alias pattern used by every other extracted module so: * `scitex.logging is scitex_logging` * Any new public name added to scitex_logging is automatically visible. Also remove the empty scitex/logging/llm/__pycache__ leftover that had no real source files behind it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`scitex-logging` has been a standalone package for a while. The umbrella's `scitex/logging/init.py` was using an explicit re-export of ~50 symbols, which silently drifts whenever scitex-logging adds new public APIs.
Replace with the standard `sys.modules` alias bridge used by every other extracted module:
Also drops a stale empty `logging/llm/` directory (only contained `pycache`).
Test plan
🤖 Generated with Claude Code