Link Prometheus symbols via Broker instead of directly #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwoj
deleted the
topic/timw/link-prometheus-via-broker-instead-of-directly
branch
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of the static binary builds started failing recently due to duplicate Civetweb/Prometheus-cpp symbols. We statically link these symbols into libbroker during build, and then attempt to link them again while linking Zeek. It's strange that this hasn't come up before, but it's possible that a recent compiler upgrade became more strict about it. Stop linking them into Zeek and use the symbols from Broker. If we ever remove Broker, this line can be uncommented again.
Related to zeek/zeek#4732