Skip to content

Link Prometheus symbols via Broker instead of directly #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timwoj merged 1 commit into from
Aug 28, 2025
Merged

Link Prometheus symbols via Broker instead of directly #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion FindPrometheusCpp.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ message("\n==================| prometheus-cpp Config Summary |================
add_subdirectory(auxil/prometheus-cpp EXCLUDE_FROM_ALL)
message("=========================================================================\n ")

set(zeekdeps ${zeekdeps} prometheus-cpp::core prometheus-cpp::pull)
# The prometheus symbols are brought by broker, which links the libraries in statically
# before Zeek links. We can skip linking them in ourselves as long as we are linking
# against broker.
#set(zeekdeps ${zeekdeps} prometheus-cpp::core prometheus-cpp::pull)

include_directories(BEFORE ${prometheuscpp_src}/pull/include ${prometheuscpp_src}/core/include)
include_directories(BEFORE ${prometheuscpp_build}/pull/include ${prometheuscpp_build}/core/include)

Expand Down
Loading