Skip to content

Add support NXP S32 HSE CRYPTO driver for S32Z270 #79351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support NXP S32 HSE CRYPTO driver for S32Z270 #79351

wants to merge 2 commits into from
+827 −1

Conversation

@haduongquang
Copy link
Contributor

@haduongquang haduongquang commented Oct 3, 2024 •
edited by Dat-NguyenDuy
Loading

This PR introduces NXP S32 HSE CRYTO driver for SoC NXP S32Z27 and enables its usage for board s32z270dc2.
Supports cryptographic operations, including hashing and symmetric ciphers, with capabilities for ECB, CBC, and CTR modes using RAM-based key catalogs with 128-bit key lengths.

tests\crypto\crypto_hash:

SUITE PASS - 100.00% [crypto_hash]: pass = 1, fail = 0, skip = 0, total = 1 duration = 0.001 seconds
 PASS - [crypto_hash.test_hash] duration = 0.001 seconds

samples\drivers\crypto:

I: Cipher Sample
I: ECB Mode
I: Output length (encryption): 0
I: ECB mode ENCRYPT - Match
I: Output length (decryption): 0
I: ECB mode DECRYPT - Match
I: CBC Mode
I: Output length (encryption): 80
I: CBC mode ENCRYPT - Match
I: Output length (decryption): 0
I: CBC mode DECRYPT - Match
I: CTR Mode
I: Output length (encryption): 0
I: CTR mode ENCRYPT - Match
I: Output length (decryption): 0
I: CTR mode DECRYPT - Match

@zephyrbot
Copy link

zephyrbot commented Oct 3, 2024 •
edited by github-actions bot
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@6d6ab91 (master) zephyrproject-rtos/hal_nxp#443 zephyrproject-rtos/hal_nxp#443/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Oct 3, 2024
@haduongquang haduongquang changed the title Add support for NXP S32 HSE CRYPTO driver for S32Z270 Add support NXP S32 HSE CRYPTO driver for S32Z270 Oct 3, 2024
@decsny decsny removed their request for review October 3, 2024 05:26
@haduongquang haduongquang force-pushed the support-hse-driver-for-s32z270 branch 3 times, most recently from dc8d870 to 2ba0f4f Compare October 3, 2024 08:01
@haduongquang
Copy link
Contributor Author

haduongquang commented Oct 3, 2024

Fixed compliance, clang and build fail.

@github-actions github-actions bot added the Stale label Jun 28, 2025
@zephyrproject-rtos zephyrproject-rtos deleted a comment from github-actions bot Jun 28, 2025
@manuargue manuargue removed the Stale label Jun 28, 2025
valeriosetti
valeriosetti requested changes Aug 4, 2025
View reviewed changes
@haduongquang haduongquang force-pushed the support-hse-driver-for-s32z270 branch from 1f24a4b to a1d60a3 Compare August 7, 2025 07:41
valeriosetti
valeriosetti previously approved these changes Aug 7, 2025
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
16.6% Duplication on New Code

See analysis details on SonarQube Cloud

@haduongquang haduongquang force-pushed the support-hse-driver-for-s32z270 branch from a1d60a3 to a00b3c7 Compare September 22, 2025 04:53
@haduongquang haduongquang force-pushed the support-hse-driver-for-s32z270 branch 2 times, most recently from fa054ef to 1f14609 Compare September 22, 2025 09:19
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 22, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
16.6% Duplication on New Code

See analysis details on SonarQube Cloud

@manuargue
Copy link
Member

manuargue commented Nov 6, 2025 •
edited
Loading

All my comments on this PR were addressed, but we have a blocker on the hal_nxp side that we are resolving internally at NXP. Once that's clarified, I will remove my block on this PR.

@haduongquang The concerns with the hal_nxp changes have been addressed and approved. Please rebase to resolve the conflicts so we can prepare this PR for merging once the freeze is lifted. Thanks!

@haduongquang
driver: crypto: add NXP S32 CRYPTO HSE driver
2386c97 
Add device tree node for MU instances that will be used by HSE and RTU
for s32z270.

Add support hash crypto for NXP S32 with Algo 2:
SHA224, SHA256, SHA384 and SHA512.

Add support cipher crypto with ECB, CBC and CTR mode by using ram key
catalog.

Add support 128/256 bits ram key length.

Signed-off-by: Ha Duong Quang <ha.duongquang@nxp.com>
@haduongquang
boards: enables support for s32z270 hse crypto
a81799a 
Enable test for s32z270 hash crypto.

Enable samples for cipher cryptoEndable samples for EBC, CBC,
CTR mode of cipher crypto.

Signed-off-by: Ha Duong Quang <ha.duongquang@nxp.com>
@haduongquang haduongquang force-pushed the support-hse-driver-for-s32z270 branch from 1f14609 to a81799a Compare November 8, 2025 13:24
@zephyrbot zephyrbot added area: Boards/SoCs area: Devicetree Bindings area: Tests Issues related to a particular existing or missing test labels Nov 8, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
16.6% Duplication on New Code

See analysis details on SonarQube Cloud

@haduongquang
Copy link
Contributor Author

haduongquang commented Nov 8, 2025

All my comments on this PR were addressed, but we have a blocker on the hal_nxp side that we are resolving internally at NXP. Once that's clarified, I will remove my block on this PR.

@haduongquang The concerns with the hal_nxp changes have been addressed and approved. Please rebase to resolve the conflicts so we can prepare this PR for merging once the freeze is lifted. Thanks!

I have rebased for both zephyr and hal_nxp.

@Dat-NguyenDuy
Copy link
Contributor

Dat-NguyenDuy commented Nov 11, 2025

The CI is failing due to #98168

@manuargue manuargue self-assigned this Nov 13, 2025
manuargue
manuargue approved these changes Nov 13, 2025
View reviewed changes
Copy link
Member

@manuargue manuargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving but we still need to merge #99190 to unblock the CI failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuargue manuargue manuargue approved these changes

@Dat-NguyenDuy Dat-NguyenDuy Dat-NguyenDuy approved these changes

@valeriosetti valeriosetti valeriosetti left review comments

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@dleach02 dleach02 Awaiting requested review from dleach02

@bperseghetti bperseghetti Awaiting requested review from bperseghetti

@carlocaione carlocaione Awaiting requested review from carlocaione

@ceolin ceolin Awaiting requested review from ceolin

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@dbaluta dbaluta Awaiting requested review from dbaluta

@kartben kartben Awaiting requested review from kartben

@MarkWangChinese MarkWangChinese Awaiting requested review from MarkWangChinese

@nashif nashif Awaiting requested review from nashif

@PetervdPerk-NXP PetervdPerk-NXP Awaiting requested review from PetervdPerk-NXP

@carlescufi carlescufi Awaiting requested review from carlescufi

@decsny decsny Awaiting requested review from decsny

Assignees

@manuargue manuargue

@ceolin ceolin

Labels

area: Boards/SoCs area: Crypto / RNG area: Devicetree Bindings area: Documentation area: mbox area: Samples Samples area: Tests Issues related to a particular existing or missing test DNM (manifest) This PR should not be merged (controlled by action-manifest) manifest manifest-hal_nxp platform: NXP Drivers NXP Semiconductors, drivers platform: NXP S32 NXP Semiconductors, S32 platform: NXP NXP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@haduongquang @zephyrbot @manuargue @Dat-NguyenDuy @ceolin @valeriosetti @fabiobaltieri