-
Notifications
You must be signed in to change notification settings - Fork 8.2k
boards: intel: Add WCL board support #99205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5aa79e2 to
5e317b2
Compare
96a6002 to
37c84c5
Compare
nordicjm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR should be split into multiple commits e.g. one for adding SoC, one for adding board
f972748 to
64adf5a
Compare
d858b24 to
3a05168
Compare
|
Moving assignment to @nordicjm as this is primarily board changes, maybe this should be assigned to @edersondisouza since it is an intel board? |
30cf465 to
18b8215
Compare
18b8215 to
7c0c0e2
Compare
nordicjm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Board files OK but commits need reordering, you cannot add a board if the SoC etc. files are missing, things must be added in order and each commit should work independently without throwing errors
7c0c0e2 to
ee6f319
Compare
I have reordered the commits |
Subsequent commits, including overlays, will compile successfully only after the base commits—SoC, board definition, and DTS—are merged. |
This commit introduces SOC support for Wildcat Lake. Signed-off-by: S Swetha <s.swetha@intel.com>
ee6f319 to
8448576
Compare
|
@nordicjm @dcpleung @andyross @tbursztyka @edersondisouza @kartben Please Review this PR |
tejlmand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit observed.
This commit introduces board defintion for Wildcat Lake. Signed-off-by: S Swetha <s.swetha@intel.com>
This commit introduces device treee source and yaml for Wildcat Lake platform Signed-off-by: S Swetha <s.swetha@intel.com>
This commit introduces overlay files for intel Wildcat lake boards Signed-off-by: S Swetha <s.swetha@intel.com>
Swap PAD_CFG1_IOSTERM_PU and PAD_CFG1_IOSTERM_PD values. Signed-off-by: S Swetha <s.swetha@intel.com>
7cf7166 to
a54d577
Compare
|
|
@tejlmand Applied the suggested changes |
edersondisouza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems some patch ordering issues are still here, otherwise looks good.
|
|
||
| #define DT_DRAM_SIZE DT_SIZE_M(2048) | ||
|
|
||
| #include <intel/wildcat_lake.dtsi> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is included in this commit, but the file is available only on the next patch... shouldn't the next patch be brought before this one - or squashed here?
dts/bindings/timer/intel,hpet.yaml
Outdated
|
|
||
| clock-frequency: | ||
| type: int | ||
| required: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required in this patch, but will be dropped on the next. So this change probably belongs to the next patch, which should be brought before this one.



This commit introduces support for Intel Wildcat Lake (WCL) enabling Zephyr RTOS to run on this platform. New additions include complete board definition and configuration, SoC support for the Wildcat Lake platform, device tree definitions and CPU bindings, GPIO driver extensions, and test overlays for peripheral validation.