-
Notifications
You must be signed in to change notification settings - Fork 8.2k
treewide: adjust CMakeLists.txt files indentation #99440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: adjust CMakeLists.txt files indentation #99440
Conversation
ec4d920 to
58840e2
Compare
|
Since this touches to every CMakeLists.txt, a second batch of commit also adds If this is too much for a single PR, then I can easily split it. |
58840e2 to
5351b5e
Compare
tejlmand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved.
Observations to be followed up.
5864af4 to
7797c11
Compare
Apply the CMake style guidelines to all CMakeList.txt files in boards/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to all CMakeList.txt files in arch/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to all CMakeList.txt files in cmake/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in drivers/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in subsys/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in samples/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in tests/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in soc/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in modules/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in share/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the "zephyr-keep-sorted-start/stop" comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
7797c11 to
40cbd53
Compare
|
force-push:
|
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
|
@tejlmand already approved, merging this now to avoid any need to rebase again given the amount of files being changed and the fact this is considered "trivial" |
The rules are interpolated from what there is on the docs:
https://docs.zephyrproject.org/latest/contribute/style/cmake.html#commands-and-syntax
And what seemed to be common on in-tree, in particular for
if()andmessages():at the end of the last continuation line
as an UPPERCASE label) the closing parenthesis is on its own line,
with same indentation level as the first line.
of "... " strings, with an empty space at the end if separation between
words is needed.
If anything seems wrong choice, let me know of what to apply and I'd be glad to apply it again tree-wide.
If the scope of modifications is wrong (i.e. should do all
CMakeLists.txtand.cmake), then let me know and I would change the scope for this PR.I am keeping it as a draft for now to avoid triggering the bot.