libc: minimal: add missing ctype.h functions #99451
Open
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
aescolar,
keith-packard,
nashif and
stephanosio
Add the functions below to the minimal libc ctype.h since they are missing, and are required as of C89 (C99 for `isblank()`) * `isblank()` * `islower()` * `ispunct()` Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
cfriedt
force-pushed
the
add-missing-ctype-functions-to-minimal-libc
branch
from
32d89a3 to
2960508
Compare
cfriedt
added
bug
|
Member
Author
|
| return (int)((c == (int)' ') || (c == (int)'\t')); | ||
| } | ||
|
|
||
| static inline int isspace(int c) |
Contributor
There was a problem hiding this comment.
I'd let the compiler do something cute if it likes, but express these in a direct fashion.
static inline int isspace (int c)
{
return c == ' ' || ('\t' <= c && c <= '\r');
}
Similarly for the other functions. There's no reason to obscure what these functions do; having to check that there are 5 'blank' values between '\t' and '\r' is something the compiler should do, not us.
keith-packard
requested changes
Nov 15, 2025
Contributor
keith-packard
left a comment
keith-packard
left a comment
There was a problem hiding this comment.
Please express these directly rather than using arithmetic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the functions below to the minimal libc
ctype.hsince they are missing, and are required as of C89 (C99 forisblank())isblank()islower()ispunct()Fixes #99452