Skip to content

Conversation

@ccli8
Copy link
Contributor

@ccli8 ccli8 commented Nov 17, 2025

This adds support for Nuvoton NuMaker M3331 series SoC CAN-FD driver.

Add support for Nuvoton's M3331 series SoC

Signed-off-by: Chun-Chieh Li <ccli8@nuvoton.com>
fabiobaltieri
fabiobaltieri previously approved these changes Nov 17, 2025
case (CLK_CANFDSEL_CANFD0SEL_HIRC48M_DIV4 >> CLK_CANFDSEL_CANFD0SEL_Pos):
*rate = (__HIRC48M / 4) / clkdiv_divider;
break;
#elif defined(CONFIG_SOC_SERIES_M333X)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's same with M46X's, just merge as:
#if defined(CONFIG_SOC_SERIES_M46X) || defined(CONFIG_SOC_SERIES_M333X)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged it

Add support for Nuvoton NuMaker-M3334KI board

This target has only 4 MPU regions, so disable userspace test.

Signed-off-by: Chun-Chieh Li <ccli8@nuvoton.com>
@sonarqubecloud
Copy link

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling userspace individual test suites doesn't scale well.

I assume this is due to a low number of MPU regions? If so, there are ways to handle this at the SoC/board level (take a look at the twr_ke18f board).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be defined at the board level, not in an individual test suite.

If this board does not support CAN on the board level, it should not have a CAN test suite overlay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Boards/SoCs area: CAN area: Tests Issues related to a particular existing or missing test platform: Nuvoton NPCM platform: Nuvoton NPCX Nuvoton NPCX platform: Nuvoton Numicro Numaker Nuvoton Technology Corporation, Numicro Numaker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants