Assignment Details Part 3 of 7: Ingest details part of shared test cases #177
+360
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarsilv
changed the title
This was referenced Dec 10, 2025
aarsilv
commented
Dec 10, 2025
| private final List<AllocationDetails> unmatchedAllocations; | ||
| private final List<AllocationDetails> unevaluatedAllocations; | ||
|
|
||
|
|
| runTestCaseBase(testCase, eppoClient, false); | ||
| } | ||
|
|
||
| public static void runTestCaseWithDetails( |
Contributor
Author
There was a problem hiding this comment.
Opted for explicit top-level methods so its clear what's going on (vs. passing a boolean, like we do do the base method)
Comment on lines
+110
to
+113
| // TODO: if validateDetails is true, call the get<type>AssignmentDetails() method | ||
| if (validateDetails) { | ||
| System.out.println("TODO: call and validate details method"); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
We will do this later once those methods are available. For now we're just setting us up to later validate details methods.
This was referenced Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚Assignment Details Stacked Pull Requests📚
☑️ AssignmentDetails return object and supporting classes (#175)
☑️ Parse more UFC metadata (#176)
👉 Ingest details part of shared test cases (#177)
🔲 FlagEvaluator computes details (#183)
🔲 Ability to unwrap EppoValue to a given type (#184)
🔲 Public assignment details methods (#181)
🔲 Bandit details (#182)
Eppo Internal
🎟️ Ticket: FFESUPPORT-378 - Implement assignment details for common Java core
Motivation and Context
We want to bring detailed assignment capabilities (e.g.,
get<Type>Details()) to Android and Java SDKs.Description
This pull request has our test case tooling ingest the details part of our shared test cases so that later we can leverage them to test the detailed assignments once we're able to request them.
How has this been documented?
Documentation will be updated for the upstream SDKs once this is incorporated into them
How has this been tested?
This chunk is untested in this pull request as they are currently unused, but will be tested later on by changes to
BaseEppoClientTest, andBaseEppoClientBanditTest.