Assignment Details Part 6 of 7: Public assignment details methods #181
+324
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarsilv
changed the base branch from
main
to
aarsilv/ffesupport-378/part5-detailsin-evaluator
This was referenced Dec 10, 2025
aarsilv
force-pushed
the
aarsilv/ffesupport-378/part5-detailsin-evaluator
branch
from
f80e705 to
30e0c46
Compare
aarsilv
changed the base branch from
aarsilv/ffesupport-378/part4-detailsin-evaluator
to
aarsilv/ffesupport-378/part5-unwrap-eppo-value
aarsilv
force-pushed
the
aarsilv/ffesupport-378/part6-details-in-eppo-client
branch
from
a8c6ead to
7f89ced
Compare
aarsilv
commented
Dec 11, 2025
| runTestCase(testCase, eppoClient); | ||
| } | ||
|
|
||
| @ParameterizedTest |
Contributor
Author
There was a problem hiding this comment.
Run through all our shared test cases, obfuscated and not, now checking details too 💪
| eppoClient.getDoubleAssignment("numeric_flag", "alice", new Attributes(), 0.0); | ||
|
|
||
| assertEquals(3.1415926, assignment, 0.0000001); | ||
| AssignmentDetails<Double> assignmentDetails = |
Contributor
Author
There was a problem hiding this comment.
Threw some details checking into this test as well so we could more easily iterate without having to run dozens of files
aarsilv
commented
Dec 11, 2025
| eppoClient.getBooleanAssignment( | ||
| flagKey, subjectKey, subjectAttributes, defaultValue.booleanValue()); | ||
| assertAssignment(flagKey, subjectAssignment, boolAssignment); | ||
| if (validateDetails) { |
Contributor
Author
There was a problem hiding this comment.
Have our testing scaffolding call and assert the results of the details methods now if we're validating details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚Assignment Details Stacked Pull Requests📚
☑️ AssignmentDetails return object and supporting classes (#175)
☑️ Parse more UFC metadata (#176)
☑️ Ingest details part of shared test cases (#177)
☑️ FlagEvaluator computes details (#183)
☑️ Ability to unwrap EppoValue to a given type (#184)
👉 Public assignment details methods (#181)
🔲 Bandit details (#182)
Eppo Internal
🎟️ Ticket: FFESUPPORT-378 - Implement assignment details for common Java core
Motivation and Context
We want to bring detailed assignment capabilities (e.g.,
get<Type>Details()) to Android and Java SDKs.Description
This pull request finally adds the
get<Type>Details()methods!How has this been documented?
Documentation will be updated for the upstream SDKs once this is incorporated into them
How has this been tested?
Added parameterized tests to run our shared test data, which includes details, in
BaseEppoClientTeset