Assignment Details Part 4 of 7: FlagEvaluator computes details #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarsilv
changed the base branch from
main
to
aarsilv/ffesupport-378/part3-ingest-test-case-details
aarsilv
force-pushed
the
aarsilv/ffesupport-378/part4-detailsin-evaluator
branch
from
405c993 to
2b203c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚Assignment Details Stacked Pull Requests📚
☑️ AssignmentDetails return object and supporting classes (#175)
☑️ Parse more UFC metadata (#176)
☑️ Ingest details part of shared test cases (#177)
👉 FlagEvaluator computes details (#183)
🔲 Ability to unwrap EppoValue to a given type (#184)
🔲 Public assignment details methods (#181)
🔲 Bandit details (#182)
Eppo Internal
🎟️ Ticket: FFESUPPORT-378 - Implement assignment details for common Java core
Motivation and Context
We want to bring detailed assignment capabilities (e.g.,
get<Type>Details()) to Android and Java SDKs.Description
This pull request changes the Flag Evaluator's evaluation to return details, instead of just the variant. For non-details assignments, we'll just pull the variant. While this means we'll be doing unnecessary work, our profiling test suggests this wont drastically hurt computation speed and it keeps the code simple.
How has this been documented?
Documentation will be updated for the upstream SDKs once this is incorporated into them
How has this been tested?
FlagEvaluatorTest,ProfileBaseEppoClientTest.java