Add detailed auditing of domain changes & comment ability#194
Merged
Conversation
This was referenced May 12, 2025
labkey-nicka
approved these changes
May 13, 2025
src/labkey/Domain.ts
Outdated
| queryName: string; | ||
| /** The domain schema name. */ | ||
| schemaName: string; | ||
| auditUserComment?: string; |
Contributor
There was a problem hiding this comment.
Add a comment for these properties. Something like:
/** Can be used to provide a comment from the user that will be attached to certain detailed audit log records. */
src/labkey/Domain.ts
Outdated
| queryName?: string; | ||
| /** Name of the schema. */ | ||
| schemaName?: string; | ||
| auditUserComment?: string; |
Contributor
There was a problem hiding this comment.
Linting will put this in order.
| containerPath: arguments[5], | ||
| includeWarnings: arguments[6], | ||
| options: arguments[7], | ||
| auditUserComment: arguments[8], |
Contributor
There was a problem hiding this comment.
nit: This isn't necessary. This interface is only intended to be backwards compatible with the original arguments list.
# Conflicts: # CHANGELOG.md # package-lock.json # package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Related Pull Requests
Changes