Add detailed auditing of domain changes & comment ability#1792
Merged
Add detailed auditing of domain changes & comment ability#1792
Conversation
This was referenced May 12, 2025
packages/components/src/internal/components/domainproperties/dataclasses/DataClassDesigner.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/internal/components/domainproperties/BaseDomainDesigner.tsx
Show resolved
Hide resolved
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
# Conflicts: # package-lock.json # package.json
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
labkey-nicka
approved these changes
May 20, 2025
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
# Conflicts: # biologics/package-lock.json # biologics/package.json # inventory/package-lock.json # inventory/package.json # sampleManagement/package-lock.json # sampleManagement/package.json
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR add support to allow user to enter additional comment during domain updates, per "requires users provide a reason before completing certain actions" setting.
Related Pull Requests
Changes
CommentTextAreainBaseDomainDesignerfor supplying user provided comment for domain updatesauditUserCommentforSampleTypeDesigner,DataClassDesignerandAssayDesignerPanels