Skip to content

Conversation

@gonzalesedwin1123
Copy link
Member

@gonzalesedwin1123 gonzalesedwin1123 commented Jan 30, 2025

Why is this change needed?

A new spp_change_request_base module is created in PR: #777 to support any change request implementations. This PR will modify the existing spp_change_request to support only the SP-MIS and Farmer Registry change request implementations.

How was the change implemented?

The spp_change_request module was modified and will depend on the new parent module spp_change_request_base. SP-MIS and Farmer Registry specific change request requirements will be maintained in this module.

New unit tests

Unit tests executed by the author

How to test manually

Related links

Enhancement to Change Request module

@gonzalesedwin1123 gonzalesedwin1123 linked an issue Jan 30, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 46.38889% with 386 lines in your changes missing coverage. Please review.

Project coverage is 74.66%. Comparing base (d50ba4c) to head (3c56bcf).
Report is 92 commits behind head on 17.0.

Files with missing lines Patch % Lines
..._change_request_base/models/mixins/source_mixin.py 19.40% 191 Missing ⚠️
spp_change_request_base/models/change_request.py 51.00% 110 Missing and 12 partials ⚠️
...nge_request_base/wizard/confirm_user_assignment.py 45.83% 26 Missing ⚠️
...hange_request_base/wizard/cancel_change_request.py 42.85% 15 Missing and 1 partial ⚠️
...hange_request_base/wizard/reject_change_request.py 48.14% 13 Missing and 1 partial ⚠️
...st_base/models/mixins/validation_sequence_mixin.py 50.00% 9 Missing ⚠️
spp_change_request_base/models/dms_file.py 57.89% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #736      +/-   ##
==========================================
- Coverage   76.23%   74.66%   -1.57%     
==========================================
  Files         687      723      +36     
  Lines       17777    18626     +849     
  Branches     2205     2351     +146     
==========================================
+ Hits        13552    13907     +355     
- Misses       3774     4241     +467     
- Partials      451      478      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@gonzalesedwin1123 gonzalesedwin1123 self-assigned this Mar 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2025
@gonzalesedwin1123 gonzalesedwin1123 deleted the 732-enhancement-to-change-request-module branch April 25, 2025 01:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants