Skip to content

Conversation

@gonzalesedwin1123
Copy link
Member

@gonzalesedwin1123 gonzalesedwin1123 commented Mar 10, 2025

Why is this change needed?

The current spp_change_request module is dependent on OpenG2P and OpenSPP base modules. There is a need for the creation of a new change request base module to be used in other implementations where OpenG2P and/or OpenSPP is not needed.

How was the change implemented?

A new spp_change_request_base module was developed and will be the parent module for implementation specific change request module. The current spp_change_request module will be modified in PR: #736 to support SP-MIS and Farmer Registry specific implementations only.

New unit tests

Unit tests executed by the author

How to test manually

Related links

Enhancement to Change Request module

…e to support non SPMIS and Farmer Registry implementations
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
36.0% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@gonzalesedwin1123 gonzalesedwin1123 linked an issue Mar 10, 2025 that may be closed by this pull request
@gonzalesedwin1123
Copy link
Member Author

To reviewers, the sonarqubecloud reported issues will be fixed in PR: #736. This is because the codes in the tests needs to be modified to resolve the code duplications issues.

@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 45.61644% with 397 lines in your changes missing coverage. Please review.

Project coverage is 75.02%. Comparing base (80a56a9) to head (546f024).

Files with missing lines Patch % Lines
..._change_request_base/models/mixins/source_mixin.py 18.87% 202 Missing ⚠️
spp_change_request_base/models/change_request.py 51.00% 110 Missing and 12 partials ⚠️
...nge_request_base/wizard/confirm_user_assignment.py 45.83% 26 Missing ⚠️
...hange_request_base/wizard/cancel_change_request.py 42.85% 15 Missing and 1 partial ⚠️
...hange_request_base/wizard/reject_change_request.py 48.14% 13 Missing and 1 partial ⚠️
...st_base/models/mixins/validation_sequence_mixin.py 50.00% 9 Missing ⚠️
spp_change_request_base/models/dms_file.py 52.94% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #777      +/-   ##
==========================================
- Coverage   76.19%   75.02%   -1.17%     
==========================================
  Files         710      727      +17     
  Lines       18498    19228     +730     
  Branches     2272     2400     +128     
==========================================
+ Hits        14094    14426     +332     
- Misses       3910     4293     +383     
- Partials      494      509      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gonzalesedwin1123 gonzalesedwin1123 merged commit 571b842 into 17.0 Mar 10, 2025
7 of 9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2025
@gonzalesedwin1123 gonzalesedwin1123 deleted the new-change-request-base-module branch April 25, 2025 01:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement to Change Request module

5 participants