This repository was archived by the owner on Apr 14, 2024. It is now read-only.
Upgrade Buttplug to latest version & add WebBluetooth check#4
Open
TheAuzzie wants to merge 1 commit intoPawCorp:masterfrom
Open
Upgrade Buttplug to latest version & add WebBluetooth check#4TheAuzzie wants to merge 1 commit intoPawCorp:masterfrom
TheAuzzie wants to merge 1 commit intoPawCorp:masterfrom
Conversation
Fixed the broken buttplug.io intergration by upgrading to the latest stable version and changing any of the API calls that were affected by the upgrade. To make the latest version of buttplug.io work I had to introduce `react-app-rewire` so we can enforce additional webpack config to load the _web_ version of buttplug rather than the node version. Additionally introduced a guard on the vibrator settings dialog to first check if WebBluetooth is actually available first before offering to connect a device to prevent misleading end users. Fixes: PawCorp#2
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the broken buttplug.io intergration by upgrading to the latest stable version and changing any of the API calls that were affected by the upgrade.
To make the latest version of buttplug.io work I had to introduce
react-app-rewireso we can enforce additional webpack config to load the web version of buttplug rather than the node version.Additionally introduced a guard on the vibrator settings dialog to first check if WebBluetooth is actually available first before offering to connect a device to prevent misleading end users.
Fixes: #2