boards/native: define FLASHFILE#11752
Merged
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom Jun 28, 2019
Merged
Conversation
Even if native does not require flashing, it is the file used for running.
Contributor
Author
|
No need to put |
This was referenced Jun 27, 2019
MrKevinWeiss
approved these changes
Jun 28, 2019
Contributor
MrKevinWeiss
left a comment
There was a problem hiding this comment.
ACK. Tested on native with FLASHFILE=/home/kevinweiss/WorkingDirectory/RIOT/examples/hello-world/bin/native/hello-world.elf make flash term -C tests/shell/
hello_world appears not the shell so flashfile was overridden.
Contributor
Author
|
Thank you for the review. You are right, I should have put the execution test as I modified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Define FLASHFILE for
native.Even if native does not require flashing, it is the file used for running.
Testing procedure
The variable is set correctly and can be overwritten from the environment.
Issues/PRs references
Part of introducing FLASHFILE #8838