Skip to content

boards/native: define FLASHFILE#11752

Merged
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/board/native/flashfile
Jun 28, 2019
Merged

boards/native: define FLASHFILE#11752
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/board/native/flashfile

Conversation

@cladmi
Copy link
Contributor

@cladmi cladmi commented Jun 27, 2019

Contribution description

Define FLASHFILE for native.

Even if native does not require flashing, it is the file used for running.

Testing procedure

The variable is set correctly and can be overwritten from the environment.

make --no-print-directory -C examples/hello-world/ info-debug-variable-FLASHFILE
/home/harter/work/git/RIOT/examples/hello-world/bin/native/hello-world.elf

FLASHFILE=last_flashfile_missing make --no-print-directory -C examples/hello-world/ info-debug-variable-FLASHFILE
last_flashfile_missing

Issues/PRs references

Part of introducing FLASHFILE #8838

Even if native does not require flashing, it is the file used for running.
@cladmi cladmi added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports labels Jun 27, 2019
@cladmi cladmi added this to the Release 2019.07 milestone Jun 27, 2019
@cladmi cladmi requested a review from MrKevinWeiss June 27, 2019 12:30
@cladmi
Copy link
Contributor Author

cladmi commented Jun 27, 2019

No need to put CI: run test tests are run on native anyway.

Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Tested on native with FLASHFILE=/home/kevinweiss/WorkingDirectory/RIOT/examples/hello-world/bin/native/hello-world.elf make flash term -C tests/shell/
hello_world appears not the shell so flashfile was overridden.

@MrKevinWeiss MrKevinWeiss merged commit 8c987fb into RIOT-OS:master Jun 28, 2019
@cladmi
Copy link
Contributor Author

cladmi commented Jun 28, 2019

Thank you for the review.

You are right, I should have put the execution test as I modified TERMPROG.
I wrote the testing procedure before updating it during the redaction.

@cladmi cladmi deleted the pr/board/native/flashfile branch June 28, 2019 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants