Skip to content

boards: pic32-wifire: Fix uart initialization#12256

Merged
kaspar030 merged 4 commits intoRIOT-OS:masterfrom
francois-berder:fix-wifire-uart
Sep 26, 2019
Merged

boards: pic32-wifire: Fix uart initialization#12256
kaspar030 merged 4 commits intoRIOT-OS:masterfrom
francois-berder:fix-wifire-uart

Conversation

@francois-berder
Copy link
Contributor

@francois-berder francois-berder commented Sep 17, 2019 •
edited
Loading

Contribution description

stdio_uart was not working on PIC32 WiFire because STDIO_UART_DEV was not defined. This PR also includes some cleanup (remove call to uart_init in board_init, remove useless macros).

Testing procedure

Compile hello-world and check the output.

Issues/PRs references

Depends on #11986 and #12227

@francois-berder francois-berder changed the title boards: pic32-wifire Fix uart initialization boards: pic32-wifire: Fix uart initialization Sep 17, 2019
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: MIPS Platform: This PR/issue effects MIPS-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Sep 17, 2019
@benpicco benpicco requested a review from kaspar030 September 17, 2019 08:55
@benpicco benpicco added this to the Release 2019.10 milestone Sep 23, 2019
@benpicco
Copy link
Contributor

benpicco commented Sep 23, 2019

The changes look good and UART is broken now anyway - please squash.

@benpicco benpicco mentioned this pull request Sep 24, 2019
Merged
@kaspar030
Copy link
Contributor

kaspar030 commented Sep 24, 2019

This is broken because default for stdio_uart is 115200, but boards/pic32-wifire/Makefile.include sets BAUD ?= 9600. Removing that line makes this work fine with 115200 baud.

I'll push a change here.

@kaspar030
Copy link
Contributor

kaspar030 commented Sep 24, 2019

This is broken because default for stdio_uart is 115200, but boards/pic32-wifire/Makefile.include sets BAUD ?= 9600. Removing that line makes this work fine with 115200 baud.

I'll push a change here.

Sorry, that got introduced by #9259.

@kaspar030
Copy link
Contributor

kaspar030 commented Sep 24, 2019

Please squash, rebase on #9259 (or wait until that is merged), and when resolving the conflicts remove that "BAUD?=9600" line...

Otherwise ACK, I tested that combination.

@miri64
Copy link
Member

miri64 commented Sep 24, 2019

(#9259 was merged)

@francois-berder
boards: pic32-wifire: Define STDIO_UART_DEV
30656bd 
Signed-off-by: Francois Berder <18538310+francois-berder@users.noreply.github.com>
@francois-berder
boards: pic32-wifire: Fix initialization of UART
738550e 
uart_init should not be called from board_init. stdio_init is responsible for
initializing debug UART device.

Signed-off-by: Francois Berder <18538310+francois-berder@users.noreply.github.com>
@francois-berder
cpu: mips32r2_common: Use stdio_uart to handle UHI write syscalls
1673f89 
Signed-off-by: Francois Berder <18538310+francois-berder@users.noreply.github.com>
@francois-berder
boards: pic32-wifire: Use default value of BAUD
7e3e827 
Signed-off-by: Francois Berder <18538310+francois-berder@users.noreply.github.com>
@francois-berder
Copy link
Contributor Author

francois-berder commented Sep 25, 2019

Rebased and squashed.

This is broken because default for stdio_uart is 115200, but boards/pic32-wifire/Makefile.include sets BAUD ?= 9600. Removing that line makes this work fine with 115200 baud.

My last commit takes care of that.

kaspar030
kaspar030 approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Works like a charm.

@kaspar030 kaspar030 merged commit c028c21 into RIOT-OS:master Sep 26, 2019
@kaspar030
Copy link
Contributor

kaspar030 commented Sep 26, 2019

Thanks @francois-berder!

@francois-berder francois-berder deleted the fix-wifire-uart branch September 26, 2019 11:34
This was referenced Nov 19, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

Assignees

No one assigned

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: MIPS Platform: This PR/issue effects MIPS-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2019.10

Development

Successfully merging this pull request may close these issues.

4 participants

@francois-berder @benpicco @kaspar030 @miri64