sys/ztimer: make ztimer_xtimer_compat use ztimer64_usec#17365
Closed
kaspar030 wants to merge 11 commits intoRIOT-OS:masterfrom
Closed
sys/ztimer: make ztimer_xtimer_compat use ztimer64_usec#17365kaspar030 wants to merge 11 commits intoRIOT-OS:masterfrom
kaspar030 wants to merge 11 commits intoRIOT-OS:masterfrom
Conversation
kaspar030
added
Impact: major
Contributor
Author
|
let's see ... |
github-actions
bot
added
Area: build system
kaspar030
force-pushed
the
ztimer_xtimer_compat_64
branch
2 times, most recently
from
bee6104 to
cb6d856
Compare
github-actions
bot
added
Area: cpu
kaspar030
added
State: waiting for other PR
Contributor
|
Shouldn't we deprecate it first? |
Contributor
Author
Well, the API still works, there's a 100% replacement now. We could keep xtimer. honestly, removing was just much easier. |
kaspar030
force-pushed
the
ztimer_xtimer_compat_64
branch
from
f38526c to
bc8187b
Compare
kaspar030
added
the
CI: ready for build
kaspar030
force-pushed
the
ztimer_xtimer_compat_64
branch
from
046bda8 to
be4435f
Compare
github-actions
bot
removed
Platform: ESP
fjmolinas
reviewed
Dec 15, 2021
Contributor
fjmolinas
left a comment
fjmolinas
left a comment
There was a problem hiding this comment.
Maybe modify .murdock so Kconfig is not built? lets look at that in a second stage IMO
Contributor
|
Maybe rebase on #17367 as well to fix the mulle issue ;) |
kaspar030
force-pushed
the
ztimer_xtimer_compat_64
branch
from
be4435f to
6e229f0
Compare
github-actions
bot
removed
Area: Kconfig
fjmolinas
added
the
CI: ready for build
kaspar030
requested review from
MichelRottleuthner,
aabadie,
cgundogan,
jia200x,
leandrolanzieri,
miri64 and
smlng
as code owners
fjmolinas
force-pushed
the
ztimer_xtimer_compat_64
branch
from
218fa71 to
aceda58
Compare
Contributor
|
Let's see If I fiddled out all the issues... will probably need to split some changes... |
Closed
fjmolinas
reviewed
Mar 2, 2022
| @@ -0,0 +1,25 @@ | |||
| ifneq (,$(filter xtimer,$(USEMODULE))) | |||
Contributor
There was a problem hiding this comment.
This change was not menat to be here, but as its never included it did not change anything
This was referenced Mar 2, 2022
Contributor
|
I split out all commits lets leave this one as is since it shows that with this the build succeeds! |
Contributor
|
This one can be closed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR removes xtimer code. The API is still provided by wrapping on ztimer(64).(one step at a time).This PR makes ztimer_xtimer_compat use ztimer64_usec. This should make it a drop-in replacement for xtimer.
Testing procedure
Issues/PRs references
Waiting for #17386