feat: connect synth runtime to canonical voices#1015
Draft
ChuxiJ wants to merge 1 commit intofeat/v0.0.x-sprint-01-engine-and-piano-rollfrom
Draft
feat: connect synth runtime to canonical voices#1015ChuxiJ wants to merge 1 commit intofeat/v0.0.x-sprint-01-engine-and-piano-rollfrom
ChuxiJ wants to merge 1 commit intofeat/v0.0.x-sprint-01-engine-and-piano-rollfrom
Conversation
This was referenced Mar 27, 2026
Author
|
Triage: Base of synth chain — This is the base PR for the synth improvement stack (#1015 → #1018 → #1019 → #1060). Needs rebase and review before the rest of the chain can progress. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tone.Synthvoices toTone.MonoSynthso filter, filter envelope, detune, and fat-oscillator unison settings affect real playbackTone.FMSynthvoices with mapped carrier/modulator settingsVerification
npx tsc --noEmitnpx vitest run src/engine/__tests__/SynthEngine.test.ts tests/unit/SynthInstrumentEditor.test.tsx tests/unit/PianoRoll.test.tsx tests/unit/VirtualKeyboard.test.tsx tests/unit/trackPresets.test.tsx src/utils/__tests__/trackInstrument.test.ts tests/unit/pianoRollContextMenu.test.tsx tests/unit/sessionLaunchModes.test.ts tests/unit/sessionLegato.test.tsnpm run buildNotes