Skip to content

feat: add synth drive character runtime#1060

Closed
ChuxiJ wants to merge 1 commit intofeat/v0.0.x-sprint-01-slide-offline-parityfrom
feat/v0.0.x-sprint-01-drive-character-runtime
Closed

feat: add synth drive character runtime#1060
ChuxiJ wants to merge 1 commit intofeat/v0.0.x-sprint-01-slide-offline-parityfrom
feat/v0.0.x-sprint-01-drive-character-runtime

Conversation

@ChuxiJ
Copy link
Copy Markdown

@ChuxiJ ChuxiJ commented Mar 27, 2026

Summary

  • add a canonical synth character spec for subtractive filter drive
  • insert a dedicated drive/distortion rack into the synth playback chain before modulation and output gain
  • cover drive mapping with focused SynthEngine node tests

Validation

  • npx tsc --noEmit
  • npx vitest run --environment node src/engine/tests/SynthEngine.test.ts
  • npm run build
  • headless Chromium smoke: app loads, window.__store / window.__uiStore available, Piano Roll opens, synth editor still renders Filter Drive and Filter Envelope

Notes

  • this keeps the existing MonoSynth filter gain/exponent mapping and adds an explicit audible character stage on top
  • Playwright MCP browser is still blocked on this machine by the existing Chrome persistent-session issue, so browser smoke used inline headless Chromium instead

Copy link
Copy Markdown
Author

ChuxiJ commented Mar 27, 2026

Triage: Stacked draft PR — Part of the synth improvement chain (#1015#1018#1019#1060). All are drafts except #1015. Defer until chain base is reviewed.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant