feat: align offline renders with canonical instruments#1019
Closed
ChuxiJ wants to merge 1 commit intofeat/v0.0.x-sprint-01-modulation-runtimefrom
Closed
feat: align offline renders with canonical instruments#1019ChuxiJ wants to merge 1 commit intofeat/v0.0.x-sprint-01-modulation-runtimefrom
ChuxiJ wants to merge 1 commit intofeat/v0.0.x-sprint-01-modulation-runtimefrom
Conversation
31 tasks
Author
This was referenced Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
track.instrumentstate instead of relying on legacysynthPresetmirrorsDetails
createSynthPlaybackChain(...)fromSynthEngineand reuse it inofflineRendergetTrackInstrumentPlaybackSource(...)andgetTrackSamplerPlaybackState(...)helpers to normalize piano-roll render inputs across callersexportMix,bounceInPlace,freezeTrack, andprojectSharingServiceto use the canonical playback helpersexportMixtest file plus helper/freeze-service assertions for canonical FM and sampler pathsValidation
npx tsc --noEmitnpx vitest run --environment node src/engine/__tests__/SynthEngine.test.ts src/utils/__tests__/trackInstrument.test.ts src/engine/__tests__/exportMix.test.ts src/services/__tests__/freezeTrackService.test.tsnpm run buildcurl --noproxy '*' -I http://127.0.0.1:4175/returned200 OKduring local smoke after starting the dev serverNotes